Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code/fix #529

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Code/fix #529

wants to merge 2 commits into from

Conversation

romashka-btc
Copy link

Fix: Replaced shell form with exec form and corrected typo in README.md

What was changed

  1. Replaced shell form with exec form in Dockerfile:
    • Updated CMD to use exec form for better consistency and reliability.
  2. Corrected typo in README.md:
    • Replaced thredhold with threshold for improved clarity and professionalism.

Why these changes were made

  • Using exec form in CMD instructions is recommended as it avoids issues with signal forwarding and improves container behavior.
  • Fixing typos ensures documentation is clear, professional, and easy to understand for readers.

Additional Notes

  • These changes improve Dockerfile consistency and the quality of documentation without altering functionality.

@colmazia colmazia requested a review from RogerKSI December 18, 2024 10:17
@RogerKSI RogerKSI requested a review from taobun December 23, 2024 10:28
Copy link
Member

@taobun taobun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your recommendation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants